[Asterisk-code-review] res_http_websocket: Add data masking to the websocket client (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Jun 15 10:47:48 CDT 2020


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14520 )

Change subject: res_http_websocket: Add data masking to the websocket client
......................................................................


Patch Set 1:

(1 comment)

This looks like the correct implementation so go ahead and cherry-pick to the 13, 16 and 17 branches.

https://gerrit.asterisk.org/c/asterisk/+/14520/1/res/res_http_websocket.c 
File res/res_http_websocket.c:

https://gerrit.asterisk.org/c/asterisk/+/14520/1/res/res_http_websocket.c@287 
PS1, Line 287: static void websocket_mask_payload(struct ast_websocket *session, char *frame, char *payload, uint64_t payload_size);
I'd just move the function here instead of declaring it here and defining it below.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14520
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id465030f2b1997b83d408933fdbabe01827469ca
Gerrit-Change-Number: 14520
Gerrit-PatchSet: 1
Gerrit-Owner: Moises Silva <moises.silva at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 15 Jun 2020 15:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200615/e85de3d5/attachment.html>


More information about the asterisk-code-review mailing list