[Asterisk-code-review] manager - Add Content-Type parameter to the SendText action (asterisk[certified/16.8])

Joshua Colp asteriskteam at digium.com
Fri Jun 12 05:33:25 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14513 )

Change subject: manager - Add Content-Type parameter to the SendText action
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14513/1/main/channel.c 
File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/14513/1/main/channel.c@3850 
PS1, Line 3850: 					ast_sendtext_data(chan, (struct ast_msg_data *)read_action_payload->payload);
This changes this frame so it can kind of be construed as an ABI change. Should there instead be a second frame type for msg data type?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14513
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: Ibb5315702532c6b954e1498beddc8855fabdf4bb
Gerrit-Change-Number: 14513
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 12 Jun 2020 10:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200612/6df3e867/attachment.html>


More information about the asterisk-code-review mailing list