[Asterisk-code-review] resource_channels.c: Fixed wrong parameter parsing (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14510 )

Change subject: resource_channels.c: Fixed wrong parameter parsing
......................................................................


Patch Set 2:

(1 comment)

Hi Joshua, here's details.

https://gerrit.asterisk.org/c/asterisk/+/14510/2/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/14510/2/res/ari/resource_channels.c@1796 
PS2, Line 1796: 
> Can you elaborate under which situation this occurs? The test covers query parameters, and they appe […]
Sure, this is test curl command what I used.

$ curl -X "POST" "http://localhost:8088/ari/channels/create" \
>      -H 'Content-Type: application/json; charset=utf-8' \
>      -u 'asterisk:asterisk' \
>      -d $'{
>   "app": "test",
>   "endpoint": "PJSIP/mb-voip/sip:test at example.com",
>   "appArgs": "MB_DIALED=1",
>   "callerId": "helloworld"
> }'

{"message":"Endpoint must be specified"}



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14510
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I898b4c3c7ae1cde19a6840e59f498822701cf5cf
Gerrit-Change-Number: 14510
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 09 Jun 2020 12:23:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200609/20c801c2/attachment.html>