[Asterisk-code-review] res_fax: Don't start a gateway if either channel is hung up (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14460 )

Change subject: res_fax: Don't start a gateway if either channel is hung up
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14460/1/res/res_fax.c 
File res/res_fax.c:

https://gerrit.asterisk.org/c/asterisk/+/14460/1/res/res_fax.c@3447 
PS1, Line 3447: 
> > Seems like it can be used here, and would even implicitly add a few more checks and logging.
> 
> Because I forgot it existed. 😊

Well, ast_check_hangup (which you wouldn't know existed because it doesn't even have "channel" in its name), sends an event AND calls ast_channel_softhangup_internal_flag_add both of which are odd for a function that is just supposed to "check".  I'm not really sure that's a good idea.   An alternative to checking hangupcause could be to call ast_channel_tech_pvt() and bail if it's not there.  Assuming it was there was the cause of the segfault in the first place.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14460
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I4e10e63b667bbb68c1c8623f977488f5d807897c
Gerrit-Change-Number: 14460
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 08 Jun 2020 00:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200607/0437e170/attachment.html>