[Asterisk-code-review] pjsip: Prevent invalid memory access when attempting to contact a non... (asterisk[13])

[Walter Doekes]

Walter Doekes has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14502 )

Change subject: pjsip: Prevent invalid memory access when attempting to contact a non-sip URI
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14502/1/res/res_pjsip.c 
File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/14502/1/res/res_pjsip.c@3339 
PS1, Line 3339: 				"Endpoint '%s': Could not create dialog to invalid URI '%s'.  Is endpoint registered and reachable?\n",
> Should this log message be updated as well to include this as a possible cause?
I would think the existing message covers it.

Could not create dialog to invalid URI 'tel:123'
Could not create dialog to invalid URI 'http://example.com'



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14502
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I9f572b3677e4730458e9402719e580f8681afe2a
Gerrit-Change-Number: 14502
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 05 Jun 2020 09:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200605/cdae777a/attachment.html>