[Asterisk-code-review] res_stir_shaken: Add inbound INVITE support. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14447 )

Change subject: res_stir_shaken: Add inbound INVITE support.
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/14447/3/include/asterisk/res_pjsip.h 
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/14447/3/include/asterisk/res_pjsip.h@2222 
PS3, Line 2222: on an incoming INVITE
It's not INVITE specific.  Any rdata will work.


https://gerrit.asterisk.org/c/asterisk/+/14447/3/include/asterisk/res_pjsip.h@2224 
PS3, Line 2224: INVITE
rdata


https://gerrit.asterisk.org/c/asterisk/+/14447/3/include/asterisk/res_pjsip.h@2228 
PS3, Line 2228:  * \retval The header value on success
You may want to add a note that the pointer is from the rdata pool and shouldn't be freed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I855f857be3d1c63b64812ac35d9ce0534085b913
Gerrit-Change-Number: 14447
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 04 Jun 2020 14:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200604/55ef4b64/attachment.html>