[Asterisk-code-review] Compiler fixes for gcc 10 (asterisk[master])

[Kinsey Moore]

Kinsey Moore has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14451 )

Change subject: Compiler fixes for gcc 10
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14451/2/include/asterisk/app.h 
File include/asterisk/app.h:

https://gerrit.asterisk.org/c/asterisk/+/14451/2/include/asterisk/app.h@1239 
PS2, Line 1239: 			char *argv[sizeof(struct {arglist}) / sizeof(char)]; \
Shouldn't this be sizeof(char*)? Each argument in arglist is defined using AST_APP_ARG() which uses char* just above. While this would technically work, it would consume 4x more space than required.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14451
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I54718496eb0c3ce5bd6d427cd279a29e8d2825f9
Gerrit-Change-Number: 14451
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Kinsey Moore <nyphbl8d at gmail.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 03:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200601/24ff7947/attachment.html>