[Asterisk-code-review] ACN: Changes specific to the core (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14688 )

Change subject: ACN: Changes specific to the core
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14688/2/main/channel.c 
File main/channel.c:

https://gerrit.asterisk.org/c/asterisk/+/14688/2/main/channel.c@1254 
PS2, Line 1254: 		.data.ptr = (void *) &topology,
              : 		.datalen = sizeof(topology)
> I don't think we can rely on the caller to hold onto the topologies ref and pointer while it's passe […]
You cannot put anything in this pointer that is allocated or holds a resource.  There is no way to know when to free the resource.  Nor does duping the frame know that the resource needs to be copied or ref bumped.

Another thing is that IAX2 can pass frames literally over the wire.  I did add a check in chan_iax2 to filter out frames that cannot be passed over the wire.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14688
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0115d2ed68d6bae0f87e85abcf16c771bdaf992c
Gerrit-Change-Number: 14688
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 28 Jul 2020 19:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200728/e0635499/attachment.html>