[Asterisk-code-review] res_pjsip_session: Ensure reused streams have correct bundle group (asterisk[certified/16.8])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14695 )

Change subject: res_pjsip_session: Ensure reused streams have correct bundle group
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14695/1/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/14695/1/res/res_pjsip_session.c@493 
PS1, Line 493: 			if (session->endpoint->media.bundle && session_media->bundle_group == -1) {
I think this is incomplete. In remove_stream_from_bundle the mid and bundle are also unset, so I think they need to also be set here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14695
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: Ie2b792220f9291587ab5f9fd123145559dba96d7
Gerrit-Change-Number: 14695
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 24 Jul 2020 14:53:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200724/832261cf/attachment.html>