[Asterisk-code-review] websocket / pjsip: Increase maximum packet size. (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Jul 22 14:49:16 CDT 2020


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14692 )

Change subject: websocket / pjsip: Increase maximum packet size.
......................................................................


Patch Set 2:

(2 comments)

The commit message should probably be updated to indicate the other changes that were made specifically in res_http_websocket.

https://gerrit.asterisk.org/c/asterisk/+/14692/2//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14692/2//COMMIT_MSG@10 
PS2, Line 10: SDPS
SDPs


https://gerrit.asterisk.org/c/asterisk/+/14692/2/res/res_http_websocket.c 
File res/res_http_websocket.c:

https://gerrit.asterisk.org/c/asterisk/+/14692/2/res/res_http_websocket.c@643 
PS2, Line 643: ntohl
This is not directly related, but it's been a bug forever: this needs to be ntohll.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14692
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I31d4351d70c8e2c11564807a7528b984f3fbdd01
Gerrit-Change-Number: 14692
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 22 Jul 2020 19:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200722/828e4f19/attachment.html>


More information about the asterisk-code-review mailing list