[Asterisk-code-review] utf8.c: Add UTF-8 validation and utility functions (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14640 )

Change subject: utf8.c: Add UTF-8 validation and utility functions
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14640/7/main/utf8.c 
File main/utf8.c:

https://gerrit.asterisk.org/c/asterisk/+/14640/7/main/utf8.c@269 
PS7, Line 269: 	ast_test_validate(test, !ast_utf8_is_valid("\xc0\x00")); /* Overlong */
> Not sure if you're testing what you want to test here. Since the NUL terminates the string anyway. Perhaps check \xc0\x80 instead?

Good catch. Fixed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14640
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I3555d787a79e7c780a7800cd26e0b5056368abf9
Gerrit-Change-Number: 14640
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-CC: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Mon, 20 Jul 2020 13:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200720/f284d971/attachment-0001.html>