[Asterisk-code-review] stasis_bridge.c: Fixed wrong video_mode shown (asterisk[master])

sungtae kim asteriskteam at digium.com
Sun Jul 12 10:39:00 CDT 2020


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14633 )

Change subject: stasis_bridge.c: Fixed wrong video_mode shown
......................................................................


Patch Set 2:

(2 comments)

Hi Sean,

Thank you for your reviewing. I've updated it. 😊

https://gerrit.asterisk.org/c/asterisk/+/14633/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14633/1//COMMIT_MSG@7 
PS1, Line 7: stasis_brdige
> bridge is spelled wrong
Oops!


https://gerrit.asterisk.org/c/asterisk/+/14633/1/main/bridge.c 
File main/bridge.c:

https://gerrit.asterisk.org/c/asterisk/+/14633/1/main/bridge.c@5166 
PS1, Line 5166: 	ast_cli(a->fd, "Video_mode: %u\n", snapshot->video_mode);
> For consistency with the other lines, this should be Video-Mode (dash instead of underscore and a ca […]
Ah, sure. Btw, I found ast_bridge_video_mode_to_string() function. Replaced it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14633
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8c205126724e34c2bdab9380f523eb62478e4295
Gerrit-Change-Number: 14633
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sun, 12 Jul 2020 15:39:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200712/d49b3c4a/attachment.html>


More information about the asterisk-code-review mailing list