[Asterisk-code-review] res_stir_shaken: Add stir_shaken option and general improvements. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14574 )

Change subject: res_stir_shaken: Add stir_shaken option and general improvements.
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14574/7/configs/samples/pjsip.conf.sample 
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/14574/7/configs/samples/pjsip.conf.sample@349 
PS7, Line 349: ; STIR/SHAKEN support. If this is enabled, STIR/SHAKEN operations will be
             : ; performed on this endpoint. This includes inbound and outbound INVITEs.
             : ; On an inbound INVITE, Asterisk will check for an Identity header and
             : ; attempt to verify the call. On an outbound INVITE, Asterisk will add an
             : ; Identity header that others can use to verify calls from this endpoint.
             : ; Additional configuration is done in stir_shaken.conf.
             : ;
I think this needs to be clear that you have to use the dialplan functions to get the results of the verification and that nothing automatically happens to the call if the verification fails.

The option is also missing from the full endpoint section below.  These are just examples.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14574
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I43d67f1489b8c1c5729ed3ca8d71e35ddf438df1
Gerrit-Change-Number: 14574
Gerrit-PatchSet: 7
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 07 Jul 2020 13:14:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200707/778b6450/attachment.html>