[Asterisk-code-review] res_stir_shaken: Add stir_shaken option and general improvements. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14574 )

Change subject: res_stir_shaken: Add stir_shaken option and general improvements.
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/c/asterisk/+/14574/6/configs/samples/pjsip.conf.sample 
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/14574/6/configs/samples/pjsip.conf.sample@349 
PS6, Line 349: ; STIR/SHAKEN support
I think this could use further explanation


https://gerrit.asterisk.org/c/asterisk/+/14574/6/include/asterisk/res_pjsip.h 
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/14574/6/include/asterisk/res_pjsip.h@902 
PS6, Line 902: 	/*! Add STIR/SHAKEN support on this endpoint */
Enable, not Add


https://gerrit.asterisk.org/c/asterisk/+/14574/6/res/res_pjsip.c 
File res/res_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/14574/6/res/res_pjsip.c@1230 
PS6, Line 1230: 					<description><para>
I don't think "added" really jives, it's not language we commonly use for features.


https://gerrit.asterisk.org/c/asterisk/+/14574/6/res/res_stir_shaken.c 
File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14574/6/res/res_stir_shaken.c@156 
PS6, Line 156: /* The amount of time (in seconds) to add if no cache data is found for
This doesn't parse in my head really. Is this a default expiration if no cache data is available?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14574
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I43d67f1489b8c1c5729ed3ca8d71e35ddf438df1
Gerrit-Change-Number: 14574
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 06 Jul 2020 09:32:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200706/cef824ac/attachment.html>