[Asterisk-code-review] res_http_websocket: Add trailing zero for text strings (asterisk[master])

Nickolay V. Shmyrev asteriskteam at digium.com
Sun Jul 5 15:32:13 CDT 2020


Nickolay V. Shmyrev has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14626 )

Change subject: res_http_websocket: Add trailing zero for text strings
......................................................................


Patch Set 1:

> You cannot set anything in the buffer if the size is zero.  The caller has told us there is no size to the passed in buffer so there is no room for the string terminator.

Current code expects one more byte and sets it to zero. I'm just trying to keep the current code behavior.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14626
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a75cffeb1eb8cf01136ef30306bd623e531a2a
Gerrit-Change-Number: 14626
Gerrit-PatchSet: 1
Gerrit-Owner: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 05 Jul 2020 20:32:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200705/9720c5d7/attachment.html>


More information about the asterisk-code-review mailing list