[Asterisk-code-review] res_http_websocket: Add trailing zero for text strings (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14626 )

Change subject: res_http_websocket: Add trailing zero for text strings
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > (1 comment)
> > 
> > Did you encounter an issue with the code?  Did ast_copy_string() read past the end of a buffer here?
> 
> Yes, I catched this with valgrind. ast_copy_string reads one byte after payload buffer which causes invalid read warning.

I think a better way to fix this would be to fix ast_copy_string() to not read past the end of the source buffer for this case.  This then has the potential to fix other places.  There are two places where the function is defined; in include/asterisk/strings.h and utils/extconf.c.

Changing the function to the below should do it.

void ast_copy_string(char *dst, const char *src, size_t size),
{
	if (size) {
		while (--size && *src) {
			*dst++ = *src++;
		}
		*dst = '\0';
	}
}


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14626
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a75cffeb1eb8cf01136ef30306bd623e531a2a
Gerrit-Change-Number: 14626
Gerrit-PatchSet: 1
Gerrit-Owner: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 03 Jul 2020 16:32:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200703/911bee09/attachment.html>