[Asterisk-code-review] res_http_websocket: Add trailing zero for text strings (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14626 )

Change subject: res_http_websocket: Add trailing zero for text strings
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Did you encounter an issue with the code?  Did ast_copy_string() read past the end of a buffer here?

https://gerrit.asterisk.org/c/asterisk/+/14626/1/res/res_http_websocket.c 
File res/res_http_websocket.c:

https://gerrit.asterisk.org/c/asterisk/+/14626/1/res/res_http_websocket.c@1474 
PS1, Line 1474: 	memcpy(*buf, payload, payload_len);
I see no real difference in the code other than making it harder to read.

ast_copy_string() ensures that the string is null terminated when it copies it.  This is why one is added to payload_len.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14626
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a75cffeb1eb8cf01136ef30306bd623e531a2a
Gerrit-Change-Number: 14626
Gerrit-PatchSet: 1
Gerrit-Owner: Nickolay V. Shmyrev <nshmyrev at alphacephei.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 03 Jul 2020 00:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200702/9888e2c2/attachment.html>