[Asterisk-code-review] res_stasis: trigger cleanup after update (asterisk[16])

George Joseph asteriskteam at digium.com
Tue Jan 28 09:34:54 CST 2020


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13675 )

Change subject: res_stasis: trigger cleanup after update
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13675/2/res/res_stasis.c 
File res/res_stasis.c:

https://gerrit.asterisk.org/c/asterisk/+/13675/2/res/res_stasis.c@1720 
PS2, Line 1720: 		ao2_unlock(apps_registry);
              : 		app_update(app, handler, data);
              : 		cleanup();
I put the cleanup where it is to fix an earlier deadlock.
We should chat about this.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13675
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8f2c0b17e33bb8128441567b97fd4c7bf74a327b
Gerrit-Change-Number: 13675
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 15:34:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200128/6372ddf8/attachment.html>


More information about the asterisk-code-review mailing list