[Asterisk-code-review] RTP/ICE: Send on first valid pair. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13687 )

Change subject: RTP/ICE: Send on first valid pair.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13687/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13687/1//COMMIT_MSG@21 
PS1, Line 21: Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
This should have an ASTERISK issue


https://gerrit.asterisk.org/c/asterisk/+/13687/1/main/rtp_engine.c 
File main/rtp_engine.c:

https://gerrit.asterisk.org/c/asterisk/+/13687/1/main/rtp_engine.c@206 
PS1, Line 206: 	/*! ICE media has started, either on a valid pair or on ICE completion */
             : 	int ice_media_started;
This is an implementation detail of res_rtp_asterisk so it should be in there


https://gerrit.asterisk.org/c/asterisk/+/13687/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13687/1/res/res_rtp_asterisk.c@2270 
PS1, Line 2270: 	.on_valid_pair = ast_rtp_on_valid_pair,
If bundled is not used and an older version of pjproject is used, this will fail. A configure check needs to be added to check for this and then use it only if present. In the case of bundled it would just always be set as being available.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13687
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
Gerrit-Change-Number: 13687
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 12:12:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200127/8789eab1/attachment-0001.html>