[Asterisk-code-review] chan_pjsip: Ignore RTP that we haven't negotiated (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13503 )

Change subject: chan_pjsip: Ignore RTP that we haven't negotiated
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13503/3/res/res_pjsip_sdp_rtp.c 
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/13503/3/res/res_pjsip_sdp_rtp.c@411 
PS3, Line 411: 		ast_format_cap_append_from_cap(session->joint_caps, joint, media_type);
Does ast_format_cap_remove_by_type need to be called on session->joint_caps to clear it out so old formats aren't present?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13503
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Icc3b85cee1772026cee5dc1b68459bf9431c14a3
Gerrit-Change-Number: 13503
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 17 Jan 2020 13:45:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200117/6d8f3246/attachment.html>