[Asterisk-code-review] chan_pjsip: Unknown media codec resulting a call disconnect (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13595 )

Change subject: chan_pjsip: Unknown media codec resulting a call disconnect
......................................................................


Patch Set 2: Code-Review-1

I don't believe this is the correct fix. We should keep track of the negotiated codecs, and drop any that weren't negotiated. With this change it will still change the formats on the channel, and in some cases would still allow the frames through.

Sean Bright had another review which he abandoned at https://gerrit.asterisk.org/c/asterisk/+/13503 which was working to keep track of what was negotiated and use that to know what to drop. This matches chan_sip behavior.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13595
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8d2e5c7b16227c2cb07b322c8704d43c189ffae8
Gerrit-Change-Number: 13595
Gerrit-PatchSet: 2
Gerrit-Owner: Salah Ahmed <txrubel at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 15 Jan 2020 12:03:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200115/13c68a1f/attachment.html>