[Asterisk-code-review] func_curl: Add 'followlocation' option to CURLOPT() (asterisk[13])

Jaco Kroon asteriskteam at digium.com
Mon Jan 13 08:18:52 CST 2020


Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13587 )

Change subject: func_curl: Add 'followlocation' option to CURLOPT()
......................................................................


Patch Set 3:

(2 comments)

Sorry for being pedantic :).

https://gerrit.asterisk.org/c/asterisk/+/13587/3/funcs/func_curl.c 
File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/13587/3/funcs/func_curl.c@257 
PS3, Line 257: 		*ot = OT_BOOLEAN;
Really a shame this list isn't sorted as well, fixing that is relatively trivial, but alas, doing that now is a nasty diff.


https://gerrit.asterisk.org/c/asterisk/+/13587/3/funcs/func_curl.c@814 
PS3, Line 814: "  followlocation - Follow HTTP 3xx redirects (boolean)\n"
I'd recommend sorting this one too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13587
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I96a4ab0142f2fb7d2e96ff976f6cf7b2982c761a
Gerrit-Change-Number: 13587
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Mon, 13 Jan 2020 14:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200113/1c88d2ee/attachment.html>


More information about the asterisk-code-review mailing list