[Asterisk-code-review] netsock2: ast_addressfamily_to_sockaddrsize and ast_sockaddr_from_soc... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Thu Jan 9 18:12:00 CST 2020


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13361 )

Change subject: netsock2: ast_addressfamily_to_sockaddrsize and ast_sockaddr_from_sockaddr.
......................................................................


Patch Set 10: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13361/10/include/asterisk/netsock2.h 
File include/asterisk/netsock2.h:

https://gerrit.asterisk.org/c/asterisk/+/13361/10/include/asterisk/netsock2.h@760 
PS10, Line 760: static inline int _ast_addressfamily_to_sockaddrsize(int af, const char *file, int line, const char *func) {
Minor coding guidelines nit: the opening '{' should be at the start of the next line.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13361
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86
Gerrit-Change-Number: 13361
Gerrit-PatchSet: 10
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: snuffy <snuffy22 at gmail.com>
Gerrit-Comment-Date: Fri, 10 Jan 2020 00:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200109/2d53f844/attachment.html>


More information about the asterisk-code-review mailing list