[Asterisk-code-review] res_pjsip_pubsub: Add ability to persist generator state information. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Wed Jan 8 09:48:02 CST 2020


Hello George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13581

to look at the new patch set (#2).

Change subject: res_pjsip_pubsub: Add ability to persist generator state information.
......................................................................

res_pjsip_pubsub: Add ability to persist generator state information.

Some body generators, such as dialog-info+xml, require storing state
information which is then conveyed in the NOTIFY request itself. Up
until now there was no way for such body generators to persist this
information.

Two new API calls have been added to allow body generators to set and
get persisted data. This data is persisted out alongside the normal
persistence information and allows the body generator to restore
state information or to simply use this for normal storage of state.
State is stored in the form of JSON and it is up to the body
generator to interpret this as needed.

The dialog-info+xml body generator has been updated to take advantage
of this to persist the version number.

ASTERISK-27759

Change-Id: I5fda56c624fd13c17b3c48e0319b77079e9e27de
---
M include/asterisk/res_pjsip_pubsub.h
M res/res_pjsip_dialog_info_body_generator.c
M res/res_pjsip_pubsub.c
3 files changed, 143 insertions(+), 47 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/81/13581/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13581
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fda56c624fd13c17b3c48e0319b77079e9e27de
Gerrit-Change-Number: 13581
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200108/81e90b54/attachment.html>


More information about the asterisk-code-review mailing list