[Asterisk-code-review] res_pjsip_pubsub: Add ability to persist generator state information. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13520 )

Change subject: res_pjsip_pubsub: Add ability to persist generator state information.
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> Since multiple body generators can be called for the same subscription, how do they coordinate?

It's based on the resource. Each resource is unique and produces a single body, so the data is stored based on that.
 
> I'd suggest that the persistence data be a json object that the generators can access by key that way they can store anything that can be serialized into a json object.
> 
> set_persistence_data(sub, key, json_object)
> get_persistence_data(sub, key)
> 
> Those work on the sub's persistence_data json object.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13520
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I5fda56c624fd13c17b3c48e0319b77079e9e27de
Gerrit-Change-Number: 13520
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 08 Jan 2020 14:54:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200108/7129ec1a/attachment-0001.html>