[Asterisk-code-review] app_softhangup.c: Reduce unnecessary warning to verbose message. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Jan 7 11:14:37 CST 2020


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13511 )

Change subject: app_softhangup.c: Reduce unnecessary warning to verbose message.
......................................................................

app_softhangup.c: Reduce unnecessary warning to verbose message.

Why log a warning for something your dialplan explicitly asked for?

Change-Id: I167b90daf4c7d75dd4b7ef94849f6cef05aa43a7
---
M apps/app_softhangup.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Joshua Colp: Approved for Submit



diff --git a/apps/app_softhangup.c b/apps/app_softhangup.c
index 5c143af..2e3c7fc 100644
--- a/apps/app_softhangup.c
+++ b/apps/app_softhangup.c
@@ -117,7 +117,7 @@
 				*cut = 0;
 		}
 		if (!strcasecmp(name, args.channel)) {
-			ast_log(LOG_WARNING, "Soft hanging %s up.\n", ast_channel_name(c));
+			ast_verb(4, "Soft hanging %s up.\n", ast_channel_name(c));
 			ast_softhangup(c, AST_SOFTHANGUP_EXPLICIT);
 			if (!ast_test_flag(&flags, OPTION_ALL)) {
 				ast_channel_unlock(c);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13511
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I167b90daf4c7d75dd4b7ef94849f6cef05aa43a7
Gerrit-Change-Number: 13511
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200107/7b8c8236/attachment-0001.html>


More information about the asterisk-code-review mailing list