[Asterisk-code-review] app_chanisavail.c: Simplify dialplan using ChanIsAvail. (asterisk[16])

Richard Mudgett asteriskteam at digium.com
Mon Jan 6 19:10:43 CST 2020


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13516

to look at the new patch set (#2).

Change subject: app_chanisavail.c: Simplify dialplan using ChanIsAvail.
......................................................................

app_chanisavail.c: Simplify dialplan using ChanIsAvail.

Dialplan has to be careful about passing an empty device list or empty
positions in the list.  As a result, dialplan has to check for these
conditions before using ChanIsAvail.  Simplify dialplan by making
ChanIsAvail handle these conditions gracefully.

* Made tolerate empty positions in the device list.

* Simplified the code and eliminated some unnecessary indention.

ASTERISK-28638

Change-Id: I9e4b67e2cbf26b2417c2d03485b8568e898931d3
---
M apps/app_chanisavail.c
A doc/CHANGES-staging/app_chanisavail_empty_device_list.txt
2 files changed, 79 insertions(+), 69 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/16/13516/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13516
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I9e4b67e2cbf26b2417c2d03485b8568e898931d3
Gerrit-Change-Number: 13516
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200106/d9ee5f07/attachment.html>


More information about the asterisk-code-review mailing list