[Asterisk-code-review] sig_pri: Fix deadlock caused by sig_pri_queue_hangup (asterisk[13])

[Frederic LE FOLL]

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13505 )

Change subject: sig_pri:  Fix deadlock caused by sig_pri_queue_hangup
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> (1 comment)
> 
> A suggestion, since ast_set_hangupsource() and ast_queue_hangup() both are in the same locked section in this fix.

Update:
Test with asterisk 16.7.0 and modified sig_pri_queue_hangup(), 10 calls/s, 1 'pri show span <myspan>' per second.
Lock observed after approx 10 mn on one of the test systems (with ast_set_hangupsource() before or after ast_queue_hangup()).
No lock (yet?) on another test system (different hardwares).


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13505
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id74aaa5d4e3746063dbe9deed188eb65193cb9c9
Gerrit-Change-Number: 13505
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 03 Jan 2020 13:15:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200103/9095ae51/attachment.html>