[Asterisk-code-review] netsock2: ast_addressfamily_to_sockaddrsize and ast_sockaddr_from_soc... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13361 )

Change subject: netsock2: ast_addressfamily_to_sockaddrsize and ast_sockaddr_from_sockaddr.
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/13361/6/include/asterisk/netsock2.h 
File include/asterisk/netsock2.h:

https://gerrit.asterisk.org/c/asterisk/+/13361/6/include/asterisk/netsock2.h@749 
PS6, Line 749:  * \since 13
This should specify the specific version since this hasn't always been around for 13, in this case it would be available as of 13.31.0


https://gerrit.asterisk.org/c/asterisk/+/13361/6/include/asterisk/netsock2.h@771 
PS6, Line 771:  * \since 13
Ditto



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13361
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86
Gerrit-Change-Number: 13361
Gerrit-PatchSet: 6
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: snuffy <snuffy22 at gmail.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 17:24:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200102/f880ce26/attachment-0001.html>