[Asterisk-code-review] res_pjsip_endpoint_identifier_ip.c: Add port matching support (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13312 )

Change subject: res_pjsip_endpoint_identifier_ip.c: Add port matching support
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

Minor comments.

https://gerrit.asterisk.org/c/asterisk/+/13312/7/include/asterisk/acl.h 
File include/asterisk/acl.h:

https://gerrit.asterisk.org/c/asterisk/+/13312/7/include/asterisk/acl.h@156 
PS7, Line 156:  */
Throw in some \since


https://gerrit.asterisk.org/c/asterisk/+/13312/7/res/res_pjsip_endpoint_identifier_ip.c 
File res/res_pjsip_endpoint_identifier_ip.c:

https://gerrit.asterisk.org/c/asterisk/+/13312/7/res/res_pjsip_endpoint_identifier_ip.c@511 
PS7, Line 511: 		/* We skip SRV lookup if a colon is present, assuming a port was specified */
This would also occur for IPv6 addresses here too, not just port



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13312
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I256d5bd5d478b95f526e2f80ace31b690eebba92
Gerrit-Change-Number: 13312
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 14:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200102/86c0ec3b/attachment.html>