[Asterisk-code-review] chan_pjsip: Ignore RTP that we haven't negotiated (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13503 )

Change subject: chan_pjsip: Ignore RTP that we haven't negotiated
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13503/2/res/res_pjsip_sdp_rtp.c 
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/13503/2/res/res_pjsip_sdp_rtp.c@404 
PS2, Line 404: 	ast_format_cap_append_from_cap(session->joint_caps, joint, media_type);
I think there's a race condition here between the thread calling chan_pjsip_read and this one. It's possible for session->joint_caps to be manipulated without protection whilst a frame is being read. If done with session->channel locked this would be safe.

As well does joint_caps need to have all the existing media formats of the given type removed so that it reflects reality?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13503
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Icc3b85cee1772026cee5dc1b68459bf9431c14a3
Gerrit-Change-Number: 13503
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 02 Jan 2020 14:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200102/bce74927/attachment-0001.html>