[Asterisk-code-review] res_pjsip_session: Fixed wrong session termination (asterisk[master])

sungtae kim asteriskteam at digium.com
Fri Feb 28 09:47:43 CST 2020


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13806 )

Change subject: res_pjsip_session: Fixed wrong session termination
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> I wonder...  Is this a bug in pjproject?  Should they be sending an ACK when the SDP is invalid?

I don't think this is a bug of pjproject. Sending a ACK for 2XX response is mandatory, it written in the RFC. https://tools.ietf.org/html/rfc3261#section-13


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13806
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifa864e0e125b1a7ed2f3abd4164187e1dddc56da
Gerrit-Change-Number: 13806
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 28 Feb 2020 15:47:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200228/1253d667/attachment-0001.html>


More information about the asterisk-code-review mailing list