[Asterisk-code-review] codec negotiation: add incoming_call_offer_prefs option (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Thu Feb 27 16:15:43 CST 2020


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13842 )

Change subject: codec negotiation: add incoming_call_offer_prefs option
......................................................................


Patch Set 2:

Question: The incoming call pref uses local/remote to indicate a choice which results in the intersection of two lists. Moving forward with some other options this will be indicated by the *_limit value. Should we use *_limit here instead of just local/remote (dropping those as values here) to be consistent with the others?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13842
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I35e7a2a0c236cfb6bd9cdf89539f57a1ffefc76f
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 22:15:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200227/e208256e/attachment.html>


More information about the asterisk-code-review mailing list