[Asterisk-code-review] res/res_pjsip_sdp_rtp: Fix MOH transitions (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Thu Feb 27 13:40:52 CST 2020


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13819 )

Change subject: res/res_pjsip_sdp_rtp: Fix MOH transitions
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13819/4/include/asterisk/res_pjsip_session.h 
File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/c/asterisk/+/13819/4/include/asterisk/res_pjsip_session.h@86 
PS4, Line 86: 	/*! \brief Stream is held by remote side changed during this negotiation*/
            : 	unsigned int remotely_held_changed:1;
This needs to move to the end of the bit field declarations (after remote_ice) as it alters the bit field definitions starting with this one, and after.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13819
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I7026032a807e9c95081cb8f060400b05deb4836f
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 27 Feb 2020 19:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200227/687b734c/attachment.html>


More information about the asterisk-code-review mailing list