[Asterisk-code-review] check_expr2: fix cross-compile/hardening issues (asterisk[master])

Sebastian Kemper asteriskteam at digium.com
Wed Feb 26 12:52:27 CST 2020


Hello Sean Bright, Joshua Colp, George Joseph, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13591

to look at the new patch set (#3).

Change subject: check_expr2: fix cross-compile/hardening issues
......................................................................

check_expr2: fix cross-compile/hardening issues

When building check_expr2 with ASLR PIE hardening enabled the linker
fails. This is resolved by adding the regular compiler flags when
building the object files from ast_expr2f.c and ast_expr2.c.

Note: The STANDALONE define is removed because it is already defined in
_ASTCFLAGS. YY_NO_INPUT is defined so that the compile survives
'--enable-dev-mode'.

Also, a Makefile variable "CROSS_COMPILING" is added so that the
build system doesn't try to run check_expr2 when cross-compiling,
because that will fail the build as will.

ASTERISK-28685 #close

Signed-off-by: Sebastian Kemper <sebastian_ml at gmx.net>
Change-Id: If435b7db9f9ad8266245bda51c81c220f9658915
---
M configure
M configure.ac
M makeopts.in
M menuselect/configure
M utils/Makefile
5 files changed, 58 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/91/13591/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13591
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If435b7db9f9ad8266245bda51c81c220f9658915
Gerrit-Change-Number: 13591
Gerrit-PatchSet: 3
Gerrit-Owner: Sebastian Kemper <sebastian_ml at gmx.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200226/f77c1d7d/attachment.html>


More information about the asterisk-code-review mailing list