[Asterisk-code-review] res/res_pjsip_sdp_rtp: Fix MOH transitions (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13819 )

Change subject: res/res_pjsip_sdp_rtp: Fix MOH transitions
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13819/2/include/asterisk/res_pjsip_session.h 
File include/asterisk/res_pjsip_session.h:

https://gerrit.asterisk.org/c/asterisk/+/13819/2/include/asterisk/res_pjsip_session.h@86 
PS2, Line 86: 	/*! \brief Stream is hold by remote side changed durign this handshake */
during, and held, and I think you mean negotiation not handshake


https://gerrit.asterisk.org/c/asterisk/+/13819/2/res/res_pjsip_sdp_rtp.c 
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/13819/2/res/res_pjsip_sdp_rtp.c@1069 
PS2, Line 1069: 	if (ast_sockaddr_isnull(addrs) ||
This should have a comment here explaining what it is doing and why


https://gerrit.asterisk.org/c/asterisk/+/13819/2/res/res_pjsip_sdp_rtp.c@1080 
PS2, Line 1080: 	} 
redness



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13819
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I7026032a807e9c95081cb8f060400b05deb4836f
Gerrit-Change-Number: 13819
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 25 Feb 2020 16:57:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200225/4c2d525c/attachment.html>