[Asterisk-code-review] pjsip: Update ACLs on named ACL changes. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13814 )

Change subject: pjsip: Update ACLs on named ACL changes.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Is there any way we can filter down the endpoints and acls to those affected by the change?
> The global reload of endpoints and acls is a little scary.

Not really. You need state to do be able to really do that, of which we have minimal or none for these. I initially tried looking into ways to do it and it quickly spun out of control. There is no way to reload a specific object (which you'd need), and while there is the ability to retrieve based on fields in practice for the wizards where it matters that is inefficient. This was the least invasive way I could see, and I think in practice named ACL reloads are infrequent enough that it's fine.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13814
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ib8fee9bd9dd490db635132c479127a4114c1ca0b
Gerrit-Change-Number: 13814
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 20 Feb 2020 15:36:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200220/26aa77e0/attachment.html>