[Asterisk-code-review] RTP/ICE: Send on first valid pair. (asterisk[16])

Benjamin Keith Ford asteriskteam at digium.com
Tue Feb 18 09:51:48 CST 2020


Hello Joshua Colp, George Joseph, Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/13673

to look at the new patch set (#10).

Change subject: RTP/ICE: Send on first valid pair.
......................................................................

RTP/ICE: Send on first valid pair.

When handling ICE negotiations, it's possible that there can be a delay
between STUN binding requests which in turn will cause a delay in ICE
completion, preventing media from flowing. It should be possible to send
media when there is at least one valid pair, preventing this scenario
from occurring.

A change was added to PJPROJECT that adds an optional callback
(on_valid_pair) that will be called when the first valid pair is found
during ICE negotiation. Asterisk uses this to start the DTLS handshake,
allowing media to flow. It will only be called once, either on the first
valid pair, or when ICE negotiation is complete.

ASTERISK-28716

Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
---
M configure
M configure.ac
M include/asterisk/autoconfig.h.in
M res/res_rtp_asterisk.c
M third-party/pjproject/configure.m4
A third-party/pjproject/patches/0040-ICE-Add-callback-for-finding-valid-pair.patch
6 files changed, 178 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/73/13673/10
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13673
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
Gerrit-Change-Number: 13673
Gerrit-PatchSet: 10
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200218/2404f599/attachment.html>


More information about the asterisk-code-review mailing list