[Asterisk-code-review] res_pjsip_outbound_registration: Fix SRV failover on timeout (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Fri Feb 14 11:31:05 CST 2020


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13804 )

Change subject: res_pjsip_outbound_registration: Fix SRV failover on timeout
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 for the small typo that Richard noticed, but otherwise looks good

https://gerrit.asterisk.org/c/asterisk/+/13804/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13804/1//COMMIT_MSG@17 
PS1, Line 17: wasn't an issue if we we're traversing SRV entries, we just retried
> This sentence doesn't read well. […]
I think it's just s/we're/weren't



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13804
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I199b8274392d17661dd3ce3b4d69a3968368fa06
Gerrit-Change-Number: 13804
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 14 Feb 2020 17:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200214/675cf9f5/attachment.html>


More information about the asterisk-code-review mailing list