[Asterisk-code-review] res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13802 )

Change subject: res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/13802/1/res/res_pjsip_sdp_rtp.c 
File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/13802/1/res/res_pjsip_sdp_rtp.c@1376 
PS1, Line 1376: 	attr = PJ_POOL_ZALLOC_T(pool, pjmedia_sdp_attr);
I think it would be useful here to comment each scenario with the SDP state attribute result


https://gerrit.asterisk.org/c/asterisk/+/13802/1/res/res_pjsip_sdp_rtp.c@1379 
PS1, Line 1379: 			attr->name = STR_INACTIVE;
Why inactive here?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13802
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iaaad9fbc033cb14803d433b8a4071bc337047761
Gerrit-Change-Number: 13802
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 14 Feb 2020 15:37:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200214/e09c0962/attachment.html>