[Asterisk-code-review] res_pjsip_sdp_rtp: implement full state machine for MOH_PASSTHROUGH (testsuite[13])

[Torrey Searle]

Torrey Searle has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13803 )

Change subject: res_pjsip_sdp_rtp: implement full state machine for MOH_PASSTHROUGH
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 2:
> 
> (1 comment)
> 
> I don't completely follow what this commit has to do with a state machine, but if it makes sense to others, so be it.

I consider it a state machine because there are 4 states, and going from sendrecv to inactive requires 2 state transitions (and vice-versa)

                    recvonly<-*remotehold*-sendrecv -*localhold*->sendonly
                      -------*localhold*--->inactive<----*remotehold*---

https://gerrit.asterisk.org/c/testsuite/+/13803/2//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/testsuite/+/13803/2//COMMIT_MSG@7 
PS2, Line 7: machin
> machine?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13803
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: I8b22fe78f5cc02c2b0b888d51df296c4509b1563
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 13 Feb 2020 08:01:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200213/f65c61ed/attachment.html>