[Asterisk-code-review] RTP/ICE: Send on first valid pair. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13731 )

Change subject: RTP/ICE: Send on first valid pair.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/13731/2/configure.ac 
File configure.ac:

https://gerrit.asterisk.org/c/asterisk/+/13731/2/configure.ac@2415 
PS2, Line 2415: 
You need to move this above, where the AST_C_COMPILE_CHECK occurs as that sets the CPP flags and libs to the correct value so that the header files are found and such.


https://gerrit.asterisk.org/c/asterisk/+/13731/2/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13731/2/res/res_rtp_asterisk.c@3280 
PS2, Line 3280: 	rtp->ice_media_started = 0;
Not really needed, calloc zeroes this out anyway.


https://gerrit.asterisk.org/c/asterisk/+/13731/2/third-party/pjproject/configure.m4 
File third-party/pjproject/configure.m4:

https://gerrit.asterisk.org/c/asterisk/+/13731/2/third-party/pjproject/configure.m4@109 
PS2, Line 109: 	AC_DEFINE([HAVE_PJPROJECT_ON_VALID_PAIR], 1, [Define if using bundled pjproject.])
Not an accurate statement. "Define if your system has the on_valid_pair pjnath callback" would be more accurate.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13731
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 10 Feb 2020 12:22:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200210/98c8e086/attachment.html>