[Asterisk-code-review] doc: Fix CHANGES entries to have .txt suffix and update READMEs (asterisk[certified/16.8])

George Joseph asteriskteam at digium.com
Fri Feb 7 13:53:11 CST 2020


George Joseph has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/13734 )


Change subject: doc: Fix CHANGES entries to have .txt suffix and update READMEs
......................................................................

doc: Fix CHANGES entries to have .txt suffix and update READMEs

Although the wiki page for the new CHANGES and UPGRADE scheme
states that the files must have the ".txt" suffix, the READMEs
didn't.

Change-Id: I490306aa2cc24d6f014738e9ebbc78592efe0f05
---
M doc/CHANGES-staging/README.md
R doc/CHANGES-staging/hide_messaging_ami_events.txt
D doc/CHANGES-staging/res_fax_negotiate_both
M doc/UPGRADE-staging/README.md
4 files changed, 8 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/34/13734/1

diff --git a/doc/CHANGES-staging/README.md b/doc/CHANGES-staging/README.md
index 8a2407f..8fc51bc 100644
--- a/doc/CHANGES-staging/README.md
+++ b/doc/CHANGES-staging/README.md
@@ -9,10 +9,10 @@
 add multiple files, each with their own description. If the message is going to
 be the same for each subject, then you can add multiple subject headers to one
 file. The "Subject: xxx" line is case sensitive! For example, if you are making
-a change to PJSIP, then you might add the file "res_pjsip_my_cool_feature" to
-this directory, with a short description of what it does. If you are adding
-multiple entries, they should be done in the same commit to avoid merge
-conflicts. Here's an example:
+a change to PJSIP, then you might add the file "res_pjsip_my_cool_feature.txt" to
+this directory, with a short description of what it does.  The files must  have
+the ".txt" suffix.  If you are adding multiple entries, they should be done in
+the same commit to avoid merge conflicts. Here's an example:
 
 > Subject: res_pjsip
 > Subject: Core
diff --git a/doc/CHANGES-staging/hide_messaging_ami_events b/doc/CHANGES-staging/hide_messaging_ami_events.txt
similarity index 100%
rename from doc/CHANGES-staging/hide_messaging_ami_events
rename to doc/CHANGES-staging/hide_messaging_ami_events.txt
diff --git a/doc/CHANGES-staging/res_fax_negotiate_both b/doc/CHANGES-staging/res_fax_negotiate_both
deleted file mode 100644
index 73be756..0000000
--- a/doc/CHANGES-staging/res_fax_negotiate_both
+++ /dev/null
@@ -1,7 +0,0 @@
-Subject: res_fax
-
-Added configuration option "negotiate_both". This option is only used
-when a gateway is enabled, and a v21 preamble is detected. If this option
-is enabled, once a preamble is detected Asterisk will initiate negotiation
-requests to both T.38 enabled endpoint versus waiting, and forwarding a
-request from an initiating endpoint. Defaults to disabled.
diff --git a/doc/UPGRADE-staging/README.md b/doc/UPGRADE-staging/README.md
index 8147161..21cbe78 100644
--- a/doc/UPGRADE-staging/README.md
+++ b/doc/UPGRADE-staging/README.md
@@ -9,9 +9,10 @@
 their own description. If the message is going to be the same for each subject,
 then you can add multiple subject headers to one file. The "Subject: xxx" line
 is case sensitive! For example, if you are making a change to PJSIP, then you
-might add the file "res_pjsip_my_cool_feature" to this directory, with a short
-description of what it does. If you are adding multiple entries, they should be
-done in the same commit to avoid merge conflicts. Here's an example:
+might add the file "res_pjsip_my_cool_feature.txt" to this directory, with a
+short description of what it does. The files must have the ".txt" suffix.
+If you are adding multiple entries, they should be done in the same commit
+to avoid merge conflicts. Here's an example:
 
 > Subject: res_pjsip
 > Subject: Core

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13734
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: I490306aa2cc24d6f014738e9ebbc78592efe0f05
Gerrit-Change-Number: 13734
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200207/015833ec/attachment.html>


More information about the asterisk-code-review mailing list