[Asterisk-code-review] RTP/ICE: Send on first valid pair. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13731 )

Change subject: RTP/ICE: Send on first valid pair.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13731/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/13731/1/res/res_rtp_asterisk.c@2204 
PS1, Line 2204: #ifdef HAVE_PJPROJECT_BUNDLED
This is incomplete. You want to modify configure.ac to do a check (there's quite a few already) which then sets a specific define for this functionality. This ensures that if someone builds with a recent external PJSIP they'll get the functionality if it exists. As it stands now this will make it so they never see this functionality unless they use bundled.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13731
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867
Gerrit-Change-Number: 13731
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 06 Feb 2020 12:27:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200206/0cfeb62d/attachment.html>