[Asterisk-code-review] stasis_channels: Add asterisk_id to message generated by channel_blob... (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13726 )

Change subject: stasis_channels: Add asterisk_id to message generated by channel_blob_to_json
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13726/3/main/stasis_channels.c 
File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/13726/3/main/stasis_channels.c@1361 
PS3, Line 1361: 	res |= ast_json_object_set(to_json, "asterisk_id", ast_json_string_create(
I'm not sure if this is the correct place for this? It seems like somewhere further down the return path might better. That way it would capture all messages (as you state some seemingly don't contain the asterisk_id).

That said I do see in res/stasis/app.c - app_send(...) where the asterisk_id is being set. Which seems like a good place to do it as it adds it to all messages. I wonder why it is not being added for messages like this one? It seems like it should be. Are you seeing a warning of any kind: "Failed to append EID ..."?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13726
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I85fd92c21e7c3465059acda34adf6cfe1777147d
Gerrit-Change-Number: 13726
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvain Afchain <safchain at wazo.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 05 Feb 2020 23:50:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200205/1ca1f0cb/attachment-0001.html>