[Asterisk-code-review] chan_sip: Clarify in sample docs how directmediapermit/-acl should be... (asterisk[17])

[Friendly Automation]

Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/13759 )

Change subject: chan_sip: Clarify in sample docs how directmediapermit/-acl should be used
......................................................................

chan_sip: Clarify in sample docs how directmediapermit/-acl should be used

It said "restrict [...] which peers should be able to pass [audio]
to each other".

However, these settings are not global (for which you would expect
signaling IPs to be checked). These settings are available per peer
only, and the IPs being checked, are the RTP IPs.

Change-Id: I2a6c6cd7c2f5f30d1df4844e3e0308a077021660
---
M configs/samples/sip.conf.sample
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Sean Bright: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/configs/samples/sip.conf.sample b/configs/samples/sip.conf.sample
index 7971b64..4947754 100644
--- a/configs/samples/sip.conf.sample
+++ b/configs/samples/sip.conf.sample
@@ -1059,7 +1059,9 @@
                                 ; the device is actually behind NAT.
 
 ;directmediadeny=0.0.0.0/0      ; Use directmediapermit and directmediadeny to restrict
-;directmediapermit=172.16.0.0/16; which peers should be able to pass directmedia to each other
+;directmediapermit=172.16.0.0/16; which RTP source IPs should be able to pass directmedia to
+                                ; each other. Note that directmedia ACLs are not a global
+                                ; setting, but must be defined per peer.
                                 ; (There is no default setting, this is just an example)
                                 ; Use this if some of your phones are on IP addresses that
                                 ; can not reach each other directly. This way you can force

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13759
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I2a6c6cd7c2f5f30d1df4844e3e0308a077021660
Gerrit-Change-Number: 13759
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200205/21675c16/attachment-0001.html>