[Asterisk-code-review] res_pjsip_session.c: Fix compiler warnings. (asterisk[18])

George Joseph asteriskteam at digium.com
Thu Dec 31 13:12:44 CST 2020


George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15278 )

Change subject: res_pjsip_session.c: Fix compiler warnings.
......................................................................

res_pjsip_session.c: Fix compiler warnings.

AST_VECTOR_SIZE() returns a size_t.  This is not always equivalent to an
unsigned long on all machines.

Change-Id: I0a4189a104e6e3a2e2273de06620eaef19df9338
---
M res/res_pjsip_session.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index 358ef96..82ef2aa 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -5583,12 +5583,14 @@
 	}
 	if (AST_VECTOR_SIZE(&left->sessions) != AST_VECTOR_SIZE(&right->sessions)) {
 		ast_assert(!assert_on_failure);
-		SCOPE_EXIT_RTN_VALUE(0, "session vector sizes different: left %lu != right %lu\n", AST_VECTOR_SIZE(&left->sessions),
+		SCOPE_EXIT_RTN_VALUE(0, "session vector sizes different: left %zu != right %zu\n",
+			AST_VECTOR_SIZE(&left->sessions),
 			AST_VECTOR_SIZE(&right->sessions));
 	}
 	if (AST_VECTOR_SIZE(&left->read_callbacks) != AST_VECTOR_SIZE(&right->read_callbacks)) {
 		ast_assert(!assert_on_failure);
-		SCOPE_EXIT_RTN_VALUE(0, "read_callback vector sizes different: left %lu != right %lu\n", AST_VECTOR_SIZE(&left->read_callbacks),
+		SCOPE_EXIT_RTN_VALUE(0, "read_callback vector sizes different: left %zu != right %zu\n",
+			AST_VECTOR_SIZE(&left->read_callbacks),
 			AST_VECTOR_SIZE(&right->read_callbacks));
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15278
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I0a4189a104e6e3a2e2273de06620eaef19df9338
Gerrit-Change-Number: 15278
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201231/6bd1b777/attachment.html>


More information about the asterisk-code-review mailing list