[Asterisk-code-review] app_mixmonitor: cleanup datastore when monitor thread fails to launch (asterisk[16])

[Sean Bright]

Attention is currently required from: Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15235 )

Change subject: app_mixmonitor: cleanup datastore when monitor thread fails to launch
......................................................................


Patch Set 1:

(1 comment)

File apps/app_mixmonitor.c:

https://gerrit.asterisk.org/c/asterisk/+/15235/comment/d3b8f68f_3e0010c4 
PS1, Line 872: 	if (datastore && !ast_channel_datastore_remove(chan, datastore)) {
This may be overly pedantic but I don't see how either of these conditions will ever eval to false (unless calls are added to mixmonitor_ds_remove_and_free elsewhere in the file)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15235
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id4f9e958956d62473ed5ff06c98ae3436e839ff8
Gerrit-Change-Number: 15235
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 23 Dec 2020 20:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201223/54cc2b75/attachment-0001.html>