[Asterisk-code-review] res/res_pjsip_diversion: prevent crash on tel: uri in History-Info (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Torrey Searle, George Joseph.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15229 )

Change subject: res/res_pjsip_diversion: prevent crash on tel: uri in History-Info
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File res/res_pjsip_diversion.c:

https://gerrit.asterisk.org/c/asterisk/+/15229/comment/9522d4b6_52cd6cf9 
PS4, Line 390: 		if (to_info) {
Is this okay to check here now? The to_info header is checked for NULL later in set_redirecting_reason but only in a particular case. If checked here and NULL then now all processing in set_redirecting_reason is skipped.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15229
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I0320aa205f22cda511d60a2edf2b037e8fd6cc37
Gerrit-Change-Number: 15229
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Torrey Searle <tsearle at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 22 Dec 2020 18:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201222/4909ee30/attachment.html>