[Asterisk-code-review] res_pjsip_pidf_digium_body_supplement: Support Sangoma user agent. (asterisk[16])

George Joseph asteriskteam at digium.com
Wed Dec 16 07:59:41 CST 2020


Attention is currently required from: Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15223 )

Change subject: res_pjsip_pidf_digium_body_supplement: Support Sangoma user agent.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_pjsip_pidf_digium_body_supplement.c:

https://gerrit.asterisk.org/c/asterisk/+/15223/comment/1494b0c0_86bbc4a2 
PS1, Line 44: 
Might want to add a comment here to future generations that it's res_pjsip_exten_state that converts the user_agent to lower case.  Took me a few minutes to track it down.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15223
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ib99362b24b91d3cbe888d8b2fce3fad5515d9482
Gerrit-Change-Number: 15223
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 16 Dec 2020 13:59:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201216/782a0a20/attachment.html>


More information about the asterisk-code-review mailing list